Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in "npm show" #5011

Closed
wants to merge 14 commits into from
Closed
11 changes: 10 additions & 1 deletion lib/commands/view.js
Expand Up @@ -218,7 +218,7 @@ class View extends BaseCommand {
const versions = pckmnt.versions || {}
pckmnt.versions = Object.keys(versions).sort(semver.compareLoose)

// remove readme unless we asked for it
// remove readme unless we asked for it
if (args.indexOf('readme') === -1) {
delete pckmnt.readme
}
Expand All @@ -236,6 +236,15 @@ class View extends BaseCommand {
}
})

// No data has been pushed because no data is matching the specified version
if (data.length === 0 && version !== 'latest') {
const er = new Error(`No match found for version ${version}`)
er.statusCode = 404
er.code = 'E404'
er.pkgid = pckmnt._id
throw er
}

if (
!this.npm.config.get('json') &&
args.length === 1 &&
Expand Down
@@ -0,0 +1,30 @@
0 timing npm:load:whichnode Completed in 1ms
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukaskuhn-lku these debug files

1 timing config:load:defaults Completed in 0ms
2 timing config:load:file:C:\Users\kuhn-\Documents\Github\npm.cli\npmrc Completed in 2ms
3 timing config:load:builtin Completed in 2ms
4 timing config:load:cli Completed in 2ms
5 timing config:load:env Completed in 0ms
6 timing config:load:file:C:\Users\kuhn-\Documents\Github\npm.cli\test\lib\commands\tap-testdir-config-completion-sandbox\project\.npmrc Completed in 0ms
7 timing config:load:project Completed in 0ms
8 timing config:load:file:C:\Users\kuhn-\Documents\Github\npm.cli\test\lib\commands\tap-testdir-config-completion-sandbox\home\.npmrc Completed in 0ms
9 timing config:load:user Completed in 1ms
10 timing config:load:file:C:\Users\kuhn-\Documents\Github\npm.cli\test\lib\commands\tap-testdir-config-completion-sandbox\global\npmrc Completed in 0ms
11 timing config:load:global Completed in 1ms
12 timing config:load:validate Completed in 0ms
13 timing config:load:credentials Completed in 0ms
14 timing config:load:setEnvs Completed in 0ms
15 timing config:load Completed in 8ms
16 timing npm:load:configload Completed in 8ms
17 timing npm:load:mkdirpcache Completed in 1ms
18 timing npm:load:mkdirplogs Completed in 2ms
19 verbose title npm config
20 verbose argv "--prefix" "C:\\Users\\kuhn-\\Documents\\Github\\npm.cli\\test\\lib\\commands\\tap-testdir-config-completion-sandbox\\project" "--userconfig" "C:\\Users\\kuhn-\\Documents\\Github\\npm.cli\\test\\lib\\commands\\tap-testdir-config-completion-sandbox\\home\\.npmrc" "--globalconfig" "C:\\Users\\kuhn-\\Documents\\Github\\npm.cli\\test\\lib\\commands\\tap-testdir-config-completion-sandbox\\global\\npmrc" "--cache" "C:\\Users\\kuhn-\\Documents\\Github\\npm.cli\\test\\lib\\commands\\tap-testdir-config-completion-sandbox\\cache" "config"
21 timing npm:load:setTitle Completed in 1ms
22 timing config:load:flatten Completed in 4ms
23 timing npm:load:display Completed in 6ms
24 verbose logfile logs-max:10 dir:C:\Users\kuhn-\Documents\Github\npm.cli\test\lib\commands\tap-testdir-config-completion-sandbox\cache\_logs
25 verbose logfile C:\Users\kuhn-\Documents\Github\npm.cli\test\lib\commands\tap-testdir-config-completion-sandbox\cache\_logs\2022-06-12T19_00_57_659Z-debug-0.log
26 timing npm:load:logFile Completed in 7ms
27 timing npm:load:timers Completed in 0ms
28 timing npm:load:configScope Completed in 0ms
29 timing npm:load Completed in 27ms
@@ -0,0 +1,30 @@
0 timing npm:load:whichnode Completed in 1ms
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukaskuhn-lku these debug files

1 timing config:load:defaults Completed in 0ms
2 timing config:load:file:C:\Users\kuhn-\Documents\Github\npm.cli\npmrc Completed in 2ms
3 timing config:load:builtin Completed in 2ms
4 timing config:load:cli Completed in 1ms
5 timing config:load:env Completed in 0ms
6 timing config:load:file:C:\Users\kuhn-\Documents\Github\npm.cli\test\lib\commands\tap-testdir-config-completion-sandbox\project\.npmrc Completed in 1ms
7 timing config:load:project Completed in 1ms
8 timing config:load:file:C:\Users\kuhn-\Documents\Github\npm.cli\test\lib\commands\tap-testdir-config-completion-sandbox\home\.npmrc Completed in 0ms
9 timing config:load:user Completed in 0ms
10 timing config:load:file:C:\Users\kuhn-\Documents\Github\npm.cli\test\lib\commands\tap-testdir-config-completion-sandbox\global\npmrc Completed in 0ms
11 timing config:load:global Completed in 0ms
12 timing config:load:validate Completed in 0ms
13 timing config:load:credentials Completed in 0ms
14 timing config:load:setEnvs Completed in 1ms
15 timing config:load Completed in 6ms
16 timing npm:load:configload Completed in 6ms
17 timing npm:load:mkdirpcache Completed in 1ms
18 timing npm:load:mkdirplogs Completed in 1ms
19 verbose title npm config set foo
20 verbose argv "--prefix" "C:\\Users\\kuhn-\\Documents\\Github\\npm.cli\\test\\lib\\commands\\tap-testdir-config-completion-sandbox\\project" "--userconfig" "C:\\Users\\kuhn-\\Documents\\Github\\npm.cli\\test\\lib\\commands\\tap-testdir-config-completion-sandbox\\home\\.npmrc" "--globalconfig" "C:\\Users\\kuhn-\\Documents\\Github\\npm.cli\\test\\lib\\commands\\tap-testdir-config-completion-sandbox\\global\\npmrc" "--cache" "C:\\Users\\kuhn-\\Documents\\Github\\npm.cli\\test\\lib\\commands\\tap-testdir-config-completion-sandbox\\cache" "config" "set" "foo"
21 timing npm:load:setTitle Completed in 2ms
22 timing config:load:flatten Completed in 3ms
23 timing npm:load:display Completed in 4ms
24 verbose logfile logs-max:10 dir:C:\Users\kuhn-\Documents\Github\npm.cli\test\lib\commands\tap-testdir-config-completion-sandbox\cache\_logs
25 verbose logfile C:\Users\kuhn-\Documents\Github\npm.cli\test\lib\commands\tap-testdir-config-completion-sandbox\cache\_logs\2022-06-12T19_00_57_809Z-debug-0.log
26 timing npm:load:logFile Completed in 4ms
27 timing npm:load:timers Completed in 0ms
28 timing npm:load:configScope Completed in 0ms
29 timing npm:load Completed in 21ms
@@ -0,0 +1 @@
{"name":"root","version":"1.0.0","workspaces":["./packages/a"]}
@@ -0,0 +1 @@
{"name":"a","version":"1.0.0","scripts":{"test":"echo test a"}}