Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use promiseSpawn.open instead of opener #5789

Merged
merged 6 commits into from Nov 2, 2022
Merged

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Nov 1, 2022

  • deps: remove opener, @npmcli/promise-spawn@6.0.1, @npmcli/run-script@5.1.1, @npmcli/git@4.0.3, pacote@15.0.5, which@3.0.0
  • fix: use an absolute path to notepad.exe by default, correct docs
  • fix: use promiseSpawn.open instead of opener

@nlf nlf requested a review from a team as a code owner November 1, 2022 21:25
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Nov 1, 2022

found 1 benchmarks with statistically significant performance improvements

  • app-medium: no-clean:audit

found 1 benchmarks with statistically significant performance regressions

  • app-large: modules-only
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 46.786 ±2.42 27.100 ±0.68 34.463 ±14.52 27.880 ±3.66 3.960 ±0.03 4.202 ±0.14 3.340 ±0.06 17.258 ±0.33 3.376 ±0.08 4.737 ±0.05
#5789 46.543 ±3.44 26.862 ±0.14 31.956 ±9.90 28.675 ±0.31 4.412 ±0.06 4.329 ±0.00 3.362 ±0.03 17.448 ±0.46 3.229 ±0.13 5.180 ±0.62
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 34.895 ±2.45 19.157 ±0.25 17.700 ±0.60 19.959 ±0.16 3.937 ±0.04 3.847 ±0.02 3.331 ±0.07 12.976 ±0.08 3.291 ±0.06 4.632 ±0.10
#5789 32.914 ±0.96 19.371 ±0.19 17.661 ±0.10 19.598 ±0.97 3.682 ±0.21 3.818 ±0.10 3.338 ±0.19 12.627 ±0.20 3.068 ±0.03 4.060 ±0.13

These libraries now return strings by default which is what we always
want in the CLI for error reporting.

Fixes #5766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants