Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use promiseSpawn.open instead of opener #5789

Merged
merged 6 commits into from Nov 2, 2022
Merged

fix: use promiseSpawn.open instead of opener #5789

merged 6 commits into from Nov 2, 2022

Commits on Nov 1, 2022

  1. deps: remove opener, @npmcli/promise-spawn@6.0.1, @npmcli/run-script@… 

    …5.1.1, @npmcli/git@4.0.3, pacote@15.0.5, which@3.0.0
    @nlf
    nlf committed Nov 1, 2022
    Copy the full SHA
    9dc20b5 View commit details
    Browse the repository at this point in the history

  2. fix: use an absolute path to notepad.exe by default, correct docs

    @nlf
    nlf committed Nov 1, 2022
    Copy the full SHA
    30d4b1a View commit details
    Browse the repository at this point in the history

  3. fix: use promiseSpawn.open instead of opener

    @nlf
    nlf committed Nov 1, 2022
    Copy the full SHA
    7b79ea2 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. deps: pacote@15.0.6

    @lukekarrys
    lukekarrys committed Nov 2, 2022
    Copy the full SHA
    5885f73 View commit details
    Browse the repository at this point in the history

  2. deps: @npmcli/run-script@6.0.0

    @lukekarrys
    lukekarrys committed Nov 2, 2022
    Copy the full SHA
    ae47924 View commit details
    Browse the repository at this point in the history

  3. fix: don't set stdioString for any spawn/run-script calls 

    These libraries now return strings by default which is what we always
want in the CLI for error reporting.

Fixes #5766
    @lukekarrys @nlf
    lukekarrys authored and nlf committed Nov 2, 2022
    Copy the full SHA
    4098e3a View commit details
    Browse the repository at this point in the history