Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow the done-check for web login to cancel opener promise #50

Merged
merged 1 commit into from Jun 8, 2022
Merged

feat: Allow the done-check for web login to cancel opener promise #50

merged 1 commit into from Jun 8, 2022

Conversation

jumoel
Copy link
Contributor

@jumoel jumoel commented May 31, 2022 •
edited

What

  • Run the URL opener and the done-check promises in parallel
  • Finish when both promises are resolved
  • Allow the done-check to resolve the opener promise

Why

Allows the npm CLI to prompt and wait before opening a URL, while having the flow dependent on the authorization result.

References

@jumoel jumoel requested a review from a team as a code owner May 31, 2022 12:16
@jumoel jumoel mentioned this pull request May 31, 2022
Merged
@jumoel jumoel merged commit aa82de0 into main Jun 8, 2022
@jumoel jumoel deleted the jumoel/allow-weblogin-to-cancel-opener branch June 8, 2022 16:16
@github-actions github-actions bot mentioned this pull request Jun 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jumoel @nlf