Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): handle packages with no exported package.json when collecting secondary entry points for mf builds #10216

Conversation

leosvelperez
Copy link
Member

Current Behavior

When building an Angular MF application, if an npm dependency is not exporting the package.json file, the build errors. More info in #10094 (comment).

Expected Behavior

The recollection of secondary entry points for MF apps shouldn't fail the build. If the package.json of any given npm dependency can't be resolved, it should be ignored.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez requested a review from Coly010 May 9, 2022 13:45
@leosvelperez leosvelperez self-assigned this May 9, 2022
@vercel
Copy link

vercel bot commented May 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) May 9, 2022 at 1:48PM (UTC)

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leosvelperez leosvelperez merged commit 2503592 into nrwl:master May 9, 2022
@leosvelperez leosvelperez deleted the angular/mf-handle-not-exported-package-json branch May 9, 2022 14:43
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants