feat(core): support nested ignore files #10455
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
blaugold
force-pushed
the
nested-ignore-files
branch
from
924f44c
to
556165d
Compare
blaugold
force-pushed
the
nested-ignore-files
branch
from
556165d
to
b5ba9a8
Compare
blaugold
force-pushed
the
nested-ignore-files
branch
from
b5ba9a8
to
d7c9657
Compare
This change adds support for ignore files (`.gitignore` and `.nxignore`) at any level, not just the workspace root. Previously those files were not taken into account. Code to evaluate ignore files was repeated multiple times throughout the codebase and has been refactor into a utility module. Closes nrwl#10442
AgentEnder
force-pushed
the
nested-ignore-files
branch
from
cfefb90
to
b36e1a6
Compare
|
@blaugold We decided to revert the exposure of these methods in @nrwl/devkit for the time being. I understand the use-case for Nx plugins, and will likely use some of the functionality in nx-dotnet myself, but we may touch up this functionality a bit in the near future and don't want to push it as a public api just yet. Plugins that wish to do so may deep import it, but there are no guarantees that the API will remain stable yet. Feel free to reach out directly on the community slack if you'd like to talk through this a bit more. Thanks for the contribution 🎉 |
|
Thanks for the update. That's fine by me. I'm happy the PR got merged, and my main issue is resolved. |
|
@blaugold Actually, this introduced a degradation to core performance that we need to correct before it goes live. @FrozenPandaz and I will work on re-applying this PR at some point in the near future, for now @vsavkin is going to roll it back to avoid the perf hit. |
This reverts commit 36d8ee2.
This reverts commit 36d8ee2.
This reverts commit 36d8ee2.
This does actually seem to resolve the caching issue. There's a closed Nx issue about this nrwl/nx#10442 and a merged PR nrwl/nx#10455, however the PR was later reverted nrwl/nx#10455 (comment) and does not seem to have been fixed again yet as far as I can tell. I've left a note on the original issue that I think it should be re-opened.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This change adds support for ignore files (
.gitignoreand.nxignore)at any level, not just the workspace root. Previously those files were not
taken into account.
Code to evaluate ignore files was repeated multiple times throughout the
codebase and has been refactor into a utility module.
Closes #10442