New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't replace undescore #8875
Comments
I think that's fair. I think delimiting Would someone like to make a PR? The code is here: https://github.com/nrwl/nx/blob/master/packages/devkit/src/utils/names.ts#L57 |
…ating file Underscore is a character usually used for sorting purposes and is absolutely legit. There is no reason to replace it. ISSUES CLOSED: nrwl#8875
Hello I made a PR (my first contribution) following your advice @FrozenPandaz. |
Underscore is a character usually used for sorting purposes and is absolutely legit. There is no reason to replace it. ISSUES CLOSED: #8875
…when .eslintrc.js already exist (#10080) * feat(devkit): feat(devkit): don't replace begining undescore when creating file Underscore is a character usually used for sorting purposes and is absolutely legit. There is no reason to replace it. ISSUES CLOSED: #8875 * fix(linter): generator creating .eslintrc.json at the root path even when .eslintrc.js
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Description
Could we allow the underscore character and not convert it to hyphen, please?
Output:
Motivation
Underscore is a character usually used for sorting purposes and is absolutely legit. There is no reason to replace it. :)
Further renaming of generated directory (and sometimes imports) is just an unnecessary step in the workflow that could be avoided.
Suggested Implementation
Alternate Implementations
The text was updated successfully, but these errors were encountered: