Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(devkit): don't replace _ #9870

Merged
merged 1 commit into from
Apr 29, 2022
Merged

feat(devkit): don't replace _ #9870

merged 1 commit into from
Apr 29, 2022

Conversation

AloisH
Copy link
Contributor

@AloisH AloisH commented Apr 18, 2022

Underscore is a character usually used for sorting purposes and is absolutely legit. There is no reason to replace it. :)
Further renaming of generated directory (and sometimes imports) is just an unnecessary step in the workflow that could be avoided.

ISSUES CLOSED: #8875

Current Behavior

when creating a file

npx nx generate @nrwl/angular:ngrx --name=user --module=libs/user/src/lib/user.module.ts --directory=_store

we obtain

CREATE libs/user/src/lib/-store/user.actions.ts

Expected Behavior

npx nx generate @nrwl/angular:ngrx --name=user --module=libs/user/src/lib/user.module.ts --directory=_store

we obtain

CREATE libs/user/src/lib/_store/user.actions.ts

Related Issue(s)

Fixes #8875

@AloisH
feat(devkit): feat(devkit): don't replace begining undescore when cre…
f756350 
…ating file

Underscore is a character usually used for sorting purposes and is absolutely legit. There is no
reason to replace it.

ISSUES CLOSED: nrwl#8875
@nx-cloud
Copy link

nx-cloud bot commented Apr 18, 2022 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f756350. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 27 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 18, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Apr 18, 2022 at 7:43PM (UTC)

@AloisH AloisH mentioned this pull request Apr 18, 2022
Closed
1 task
@AloisH AloisH changed the title feat(devkit): feat(devkit): don't replace _ feat(devkit): don't replace _ Apr 18, 2022
FrozenPandaz
FrozenPandaz approved these changes Apr 29, 2022
View reviewed changes
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit 0bd08cc into nrwl:master Apr 29, 2022
@moniuch
Copy link

moniuch commented Apr 30, 2022

@AloisH Thanks for solving this!

jaytavares pushed a commit to CurioVision/nx that referenced this pull request Jun 8, 2022
@AloisH @jaytavares
fix(devkit): don't replace begining undescore when creating file (nrw…
2ae5bdb 
…l#9870)

Underscore is a character usually used for sorting purposes and is absolutely legit. There is no
reason to replace it.

ISSUES CLOSED: nrwl#8875
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

Assignees

@FrozenPandaz FrozenPandaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't replace undescore
3 participants
@AloisH @moniuch @FrozenPandaz