fix(nx): calculate dependencies of other targets

[wSedlacek]

Current Behavior

The task list generated does not include all task for targets when the depends on includes multiple targets ie

      "dependsOn": [
        {
          "target": "build",
          "projects": "dependencies"
        },
        {
          "target": "database",
          "projects": "dependencies"
        },
        {
          "target": "sqs-mock",
          "projects": "dependencies"
        }
      ]

This is a regression since 13.4.6 which I upgraded from when discovering this issue.

Expected Behavior

The task generated should include all task from all of the targets in the depends on.

Fixes: #10028

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2ef4524. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 13 targets

• nx affected --target=build --base=ebc3e64442f94d3d8e0c0b42366929d6d44fd9e8 --head=2ef452440fc6234f3e33290212e1a3cb29dc1d95 --parallel=3
• nx affected --target=e2e --base=ebc3e64442f94d3d8e0c0b42366929d6d44fd9e8 --head=2ef452440fc6234f3e33290212e1a3cb29dc1d95 --exclude=e2e-detox,e2e-js,e2e-next,e2e-workspace-create,e2e-workspace-integrations,e2e-workspace-core,e2e-react,e2e-web,e2e-angular-extensions,e2e-angular-core,e2e-cli,e2e-nx-plugin,e2e-cypress,e2e-node,e2e-linter,e2e-jest,e2e-a...
• nx affected --target=e2e --base=ebc3e64442f94d3d8e0c0b42366929d6d44fd9e8 --head=2ef452440fc6234f3e33290212e1a3cb29dc1d95 --exclude=e2e-storybook,e2e-react-native,e2e-detox --parallel=1
• nx affected --target=lint --base=ebc3e64442f94d3d8e0c0b42366929d6d44fd9e8 --head=2ef452440fc6234f3e33290212e1a3cb29dc1d95 --parallel=3
• nx affected --target=test --base=ebc3e64442f94d3d8e0c0b42366929d6d44fd9e8 --head=2ef452440fc6234f3e33290212e1a3cb29dc1d95 --parallel=1
• nx build typedoc-theme
• nx run-many --target=build --all --parallel=8 --exclude=docs,nx-dev-data-access-documents,nx-dev-e2e,nx-dev,nx-dev-feature-analytics,nx-dev-feature-conf,nx-dev-feature-doc-viewer,nx-dev-feature-search,nx-dev-feature-storage,nx-dev-feature-versions-and-flavors,nx-dev-ui-commands,nx-dev-ui-common,nx-dev-ui-home,nx-dev-ui-member-card,nx-dev-ui-sponsor...
• nx-cloud record -- yarn check-commit
• nx-cloud record -- yarn check-imports
• nx-cloud record -- yarn depcheck
• nx-cloud record -- yarn documentation
• nx-cloud record -- yarn nx format:check --base=ebc3e64442f94d3d8e0c0b42366929d6d44fd9e8 --head=2ef452440fc6234f3e33290212e1a3cb29dc1d95
• nx-cloud record -- yarn nx workspace-lint

---

Sent with 💌 from NxCloud.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
nx-dev	⬜️ Ignored (Inspect)		Apr 22, 2022 at 1:45AM (UTC)

[AgentEnder]

This would fix #10028, if it is correct + approved.

[FrozenPandaz]

Thanks for the contribution! LGTM 🎉

[arabull]

@AgentEnder It turns out that this only partially fixed #10028. It took care of the situation where there are two targetDependencies and dependent projects have both of them. Before this, only the first dependency would run.

What this does not address is the situation where a dependent project only has the second of the two dependencies. In that situation, that second dependency still doesn't run. In our (fairly extensive) monorepo, this is a common scenario.

I've updated the repo at https://github.com/arabull/nx-deps-not-running to reflect this. That repo offers a very simple reproduction of the problem.

What is the proper protocol? Should I file a new issue for this, or does #10028 need to be reopened?

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.