fix(js): workspace lib devDependencies should not be added to package.json #17802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ajwootto
force-pushed
the
fix-dev-dependencies
branch
from
8aea693
to
559e82e
Compare
|
Can you rebase this with master |
ajwootto
force-pushed
the
fix-dev-dependencies
branch
from
559e82e
to
9fac315
Compare
|
@ndcunningham done |
…on when listed in devDependencies
ajwootto
force-pushed
the
fix-dev-dependencies
branch
from
9fac315
to
32f6552
Compare
jaysoo
approved these changes
Sep 6, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression where libraries with dependencies on other libraries in your Nx workspace would list those dependencies in the "dependencies" output of package.json, even when explicitly listed in "devDependencies"
Note: there should probably be a test for this, which I tried to write but couldn't figure out how to get the structure of the "dependencies" argument correct. All the existing tests just pass an empty array here.
Current Behavior
Nx incorrectly outputs library dependencies in "dependencies" section of package.json even when listed in the "devDependencies" explicitly
Expected Behavior
The packages should not be listed in "dependencies". This fixes a regression introduced by this PR:
#13968
Related Issue(s)
Fixes #17758