Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): only early exit when no changelog changes if expecting commit #20568

Merged
merged 4 commits into from Dec 5, 2023

Conversation

JamesHenry
Copy link
Collaborator

@JamesHenry JamesHenry commented Dec 4, 2023

Current Behavior

Changelog command will always exit early if there are no changes ready to be flushed to disk from the tree

Expected Behavior

Changelog command will only exit early when there are no changes ready to be flushed to disk from the tree when a commit is expected to be made

Related Issue(s)

Fixes #

@JamesHenry JamesHenry requested a review from a team as a code owner December 4, 2023 18:48
Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Dec 5, 2023 1:31pm

@JamesHenry JamesHenry enabled auto-merge (squash) December 4, 2023 19:23
@JamesHenry JamesHenry merged commit 5e174fc into nrwl:master Dec 5, 2023
6 checks passed
@JamesHenry JamesHenry deleted the changelog-fix branch December 5, 2023 14:12
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants