Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): fix no such file or directory, open 'package-lock.json' #21835

Merged
merged 8 commits into from Mar 6, 2024

Conversation

alonronin
Copy link
Contributor

Current Behavior

when adding generatePackageJson: true in webpack config nx js plugin try to read lock file from project directory and not workspace root resulting in an error: HookWebpackError: ENOENT: no such file or directory, open 'package-lock.json'

Expected Behavior

should resolve from workspace root diretory.

Related Issue(s)

#21651
#21808

Fixes #21651 #21808

…, open 'package-lock.json'

when adding `generatePackageJson: true` in webpack config nx js plugin try to read lock file from project directory and not workspace root.

Closes nrwl#21651
Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Mar 6, 2024 1:07pm

@alonronin alonronin changed the title HookWebpackError: ENOENT: no such file or directory, open 'package-lock.json' fix(webpack): fix no such file or directory, open 'package-lock.json' Feb 15, 2024
@ericbf
Copy link

ericbf commented Mar 1, 2024

What’s the hold-up on this? I’m facing this issue as well and would like to see it fixed.

@meeroslav meeroslav enabled auto-merge (squash) March 5, 2024 11:01
@meeroslav
Copy link
Contributor

Thank you for the fix @alonronin!

@meeroslav meeroslav merged commit a09e70a into nrwl:master Mar 6, 2024
6 checks passed
@Bonscho
Copy link

Bonscho commented Mar 7, 2024

Please excuse my impatience. When will the fix be available with nx migrate? We are urgently waiting for this one … 

@JamesHenry
Copy link
Collaborator

JamesHenry commented Mar 7, 2024

@Bonscho it’s already available on next, which is currently 18.1.0-beta.4

18.1.1 will be released today or tomorrow most likely as well

FrozenPandaz pushed a commit that referenced this pull request Mar 8, 2024
…21835)

Co-authored-by: Miroslav Jonaš <missing.manual@gmail.com>
(cherry picked from commit a09e70a)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Nest] Nest app build failure with generatePackageJson=true - Nx 18
7 participants