Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): fix no such file or directory, open 'package-lock.json' #21835

Merged
merged 8 commits into from Mar 6, 2024
2 changes: 1 addition & 1 deletion .circleci/config.yml
Expand Up @@ -61,7 +61,7 @@ commands:
name: Install Dependencies
command: |
pnpm install --frozen-lockfile
pnpm playwright install --with-deps firefox webkit chrome
pnpm playwright install --with-deps
- save_cache:
name: Save pnpm Package Cache
key: node-deps-{{ arch }}-v3-{{ checksum "pnpm-lock.yaml" }}
Expand Down
15 changes: 14 additions & 1 deletion packages/nx/src/plugins/js/lock-file/lock-file.ts
Expand Up @@ -143,6 +143,19 @@ export function getLockFileName(packageManager: PackageManager): string {
throw new Error(`Unknown package manager: ${packageManager}`);
}

function getLockFilePath(packageManager: PackageManager): string {
if (packageManager === 'yarn') {
return YARN_LOCK_PATH;
}
if (packageManager === 'pnpm') {
return PNPM_LOCK_PATH;
}
if (packageManager === 'npm') {
return NPM_LOCK_PATH;
}
throw new Error(`Unknown package manager: ${packageManager}`);
}

/**
* Create lock file based on the root level lock file and (pruned) package.json
*
Expand All @@ -157,7 +170,7 @@ export function createLockFile(
packageManager: PackageManager = detectPackageManager(workspaceRoot)
): string {
const normalizedPackageJson = normalizePackageJson(packageJson);
const content = readFileSync(getLockFileName(packageManager), 'utf8');
const content = readFileSync(getLockFilePath(packageManager), 'utf8');

try {
if (packageManager === 'yarn') {
Expand Down