feat(web): allow unsecure ssl proxy on file-server #7449
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to http-party/http-server#688 released in v14, it's now possible to forward proxy options to http-server.
It's useful for Nx as the
@nrwl/web:file-server
executor uses it. This pull request aims to fix an issue related to this executor while a self-signed certificate is used.Example of
@nrwl/web:file-server
configuration usingsecure: false
proxy option.My proposal simply add a
secure
boolean option in the schema, but maybe you prefer a dedicated entry for proxy-options as supported by the [https://github.com/http-party/node-http-proxy#options][node-http-proxy] library.Current Behavior
Using a proxyUrl on a
@nrwl/web:file-server
executor does not work because of security purpose.Expected Behavior
@nrwl/web:file-server
is expected to be used for development only and is most of the time given a self-signed certificate.Related Issue(s)
#5118