Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): updated dependency fs-extra to ^10.0.0 #8531

Closed
wants to merge 1 commit into from

Conversation

Phillip9587
Copy link
Contributor

Current Behavior

Nx uses fs-extra ^9.1.0

Expected Behavior

Nx uses fs-extra ^10.0.0

Tests for this update are currently failing due to an error with memfs. See: streamich/memfs#803

@vercel
Copy link

vercel bot commented Jan 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/DDzpcmGGyC3TrVwCZytAzkZbyCwt
✅ Preview: https://nx-dev-git-fork-phillip9587-fs-extra-10-nrwl.vercel.app

FrozenPandaz
FrozenPandaz previously approved these changes Jan 14, 2022
@FrozenPandaz FrozenPandaz self-assigned this Jan 14, 2022
@FrozenPandaz FrozenPandaz dismissed their stale review January 14, 2022 18:42

Please fix the broken test. We'll probably have to wait for a new version of memfs.

@FrozenPandaz
Copy link
Collaborator

@Phillip9587 what is the status of this? has the issue with memfs been fixed?

@Phillip9587
Copy link
Contributor Author

@FrozenPandaz The maintainer of memfs hasn't replied yet. I'm sorry...

@FrozenPandaz
Copy link
Collaborator

Let's close this PR. We can re-make the PR once it is ready.

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants