fix(node): wait for subprocess to exit when --watch=false in execute executor
#9087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cute executor Fixes #7031. Before this fix, the executor would exit immediately and let the node subprocess continue in the background, if watch was set to false. This commit attempts to fix this problem, by adding event listeners on the subprocess in the node/execute executor if watch is false, such that the nx process continues simply (a)waits until the subprocess exists (successfully or not). Error handling has also been added such that the executor fails if a non-successful status code is returned by the program
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/uwgHgyaDVP7dJKNu6Vewc8MsTFFf |
jlndk
changed the title
--watch=false in execute executor
…t-when-watch-false
|
I think this may answer my question here: #5726 |
|
Is there anything preventing this from being merged and included in the next release? |
FrozenPandaz
approved these changes
May 6, 2022
jlndk
deleted the
issue-7031/fix-node-executor-immediate-exit-when-watch-false
branch
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7031
Current Behavior
Before this fix, the node/execute executor would exit immediately and let the node subprocess continue in the background, if watch was set to false.
Expected Behavior
This PR attempts to fix this problem, by implementing the patch suggested in #7031 (comment), adding event listeners on the subprocess if watch is false, such that the nx process simply waits until the subprocess exists (successfully or not).
Error handling has also been added such that the executor fails if a non-successful status code is returned by the program