Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): wait for subprocess to exit when --watch=false in execute executor #9087

Closed
wants to merge 2 commits into from
Closed

fix(node): wait for subprocess to exit when --watch=false in execute executor #9087

wants to merge 2 commits into from

Commits on Feb 22, 2022

  1. fix(node): wait for subprocess to exit when --watch=false in node exe…

    …cute executor
    
    Fixes #7031.
    
    Before this fix, the executor would exit immediately and let the node subprocess continue in the background,
    if watch was set to false.
    This commit attempts to fix this problem, by adding event listeners on the subprocess in the node/execute
    executor if watch is false, such that the nx process continues simply (a)waits until the subprocess exists
    (successfully or not).
    
    Error handling has also been added such that the executor fails if a non-successful status code is returned by the program
    jlndk committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    30e5c87 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Configuration menu
    Copy the full SHA
    ead5306 View commit details
    Browse the repository at this point in the history