BUG: Fix for npyv_orc_b8 and npyv_xnor_b8 for s390x (z13) #21748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement npyv_orc_b8 and npyv_xnor_b8 for z13. '__builtin_s390_vec_orc' and `__builtin_s390_vec_eqv` require z14 or higher.
|
I assume you hit this when running on a z13 machine? |
mattip
reviewed
Jun 14, 2022
|
@mattip I have observed the below error while building with from build/src.linux-s390x-3.9/numpy/core/src/umath/loops_comparison.dispatch.vx.c:8:
numpy/core/src/umath/loops_comparison.dispatch.c.src: In function 'simd_binary_equal_b8':
numpy/core/src/common/simd/vec/operators.h:148:22: error: '__builtin_s390_vec_eqv' requires z14 or higher
148 | #define npyv_xnor_b8 vec_eqv
| ^~~~~~~
numpy/core/src/umath/loops_comparison.dispatch.c.src: In function 'simd_binary_scalar1_less_equal_b8':
numpy/core/src/common/simd/vec/operators.h:147:21: error: '__builtin_s390_vec_orc' requires z14 or higher
147 | #define npyv_orc_b8 vec_orc
| ^~~~~~~cc @seiko2plus |
|
my bad, I made re-base after #21483 get merged and CI didn't detect this error!. after checking the CI build log right now, I figure out that VX features aren't detected due to weird assembler error. WARN: CCompilerOpt.dist_test[630] : CCompilerOpt._dist_test_spawn[764] : Command (gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Werror=vla -Werror=nonnull -Werror=pointer-arith -Werror=implicit-function-declaration -Wlogical-op -Wno-sign-compare -Werror=undef -fPIC -Inumpy/core/src/common -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/src/npysort -Inumpy/core/src/_simd -I/home/travis/build/numpy/numpy/builds/venv/include -I/opt/python/3.8.13/include/python3.8 -Ibuild/src.linux-s390x-3.8/numpy/core/src/common -Ibuild/src.linux-s390x-3.8/numpy/core/src/npymath -c /home/travis/build/numpy/numpy/numpy/distutils/checks/cpu_vx.c -o /tmp/tmp8y6c77l0/home/travis/build/numpy/numpy/numpy/distutils/checks/cpu_vx.o -MMD -MF /tmp/tmp8y6c77l0/home/travis/build/numpy/numpy/numpy/distutils/checks/cpu_vx.o.d -march=arch11 -mzvector -Werror) failed with exit status 1 output ->
/tmp/ccnQ53L4.s: Assembler messages:
/tmp/ccnQ53L4.s:19: Error: junk at end of line: `,3'
WARN: CCompilerOpt.feature_test[1563] : testing failed
INFO: CCompilerOpt.__init__[1807] : initialize targets groups
INFO: CCompilerOpt.__init__[1809] : parse target group simd_test
|
seiko2plus
added a commit
to seiko2plus/numpy
that referenced
this pull request
Jun 15, 2022
This guard protects against any sudden unexpected changes that may adversely
affect the compile-time SIMD features detection which could leave the SIMD code
inactivated. Until now we have faced two cases:
1. Hardening the compile-time test files of Neon/ASIMD features without checking
the sanity of the modification leading to disabling all optimizations on aarch64.
see numpygh-21747
2. A sudden compiler upgrades by CI side on s390x that causes conflicts with the
installed assembler leading to disabling the whole VX/E features, which made us
merge SIMD code without testing it. Later, it was discovered that this code
disrupted the NumPy build.
see numpygh-21750, numpygh-21748
seiko2plus
added a commit
to seiko2plus/numpy
that referenced
this pull request
Jun 15, 2022
This guard protects against any sudden unexpected changes that may adversely
affect the compile-time SIMD features detection which could leave the SIMD code
inactivated. Until now we have faced two cases:
1. Hardening the compile-time test files of Neon/ASIMD features without checking
the sanity of the modification leading to disabling all optimizations on aarch64.
see numpygh-21747
2. A sudden compiler upgrades by CI side on s390x that causes conflicts with the
installed assembler leading to disabling the whole VX/E features, which made us
merge SIMD code without testing it. Later, it was discovered that this code
disrupted the NumPy build.
see numpygh-21750, numpygh-21748
seiko2plus
added a commit
to seiko2plus/numpy
that referenced
this pull request
Jun 15, 2022
This guard protects against any sudden unexpected changes that may adversely
affect the compile-time SIMD features detection which could leave the SIMD code
inactivated. Until now we have faced two cases:
1. Hardening the compile-time test files of Neon/ASIMD features without checking
the sanity of the modification leading to disabling all optimizations on aarch64.
see numpygh-21747
2. A sudden compiler upgrades by CI side on s390x that causes conflicts with the
installed assembler leading to disabling the whole VX/E features, which made us
merge SIMD code without testing it. Later, it was discovered that this code
disrupted the NumPy build.
see numpygh-21750, numpygh-21748
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since,
__builtin_s390_vec_orcand__builtin_s390_vec_eqvrequire z14 or higher.