-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(types): add missing typescript definitions for reporters #94
Conversation
There are 3 drawback here
"skipLibCheck": true, What do you think? |
types/consola.d.ts
Outdated
export type DebugLogLevel = 4; | ||
export type TraceLogLevel = 5; | ||
export type SilentLogLevel = Infinity; | ||
export type LogLevel = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we instead use an enum?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enums won't work well on d.ts alone as you must expose a real object to represent them. I will see if I can add it to the js and then expose it as an Enum here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it, can you please CR it again?
Hi @regevbr thanks for the PR. I think based on the amount of new types it is better to rewrite lib to typescript to auto-generate them. |
Hi rewriting will take a long time and I'm no available for it right now as I'm working on other projects. Do tou think we can use those typings for now? |
Of course, we can do it until rewrite. I'm just worried about winston and log level types. Can we, for now, omit Winston and use an enum (via js) for levels? |
Great! |
Thanks @pi0! when can we expect a new release with the changes? |
@regevbr sorry for the delay. will be released in a few minutes. Thanks again for PR ❤️ :) |
Sure thing! thanks :-) |
It's out: https://github.com/nuxt-contrib/consola/releases/tag/v2.12.0 Thank you @regevbr :) |
Thanks @atinux |
Fix #92