Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(headings): don't generate link if id is missing #1893

Merged
merged 2 commits into from Feb 7, 2023
Merged

fix(headings): don't generate link if id is missing #1893

merged 2 commits into from Feb 7, 2023

Conversation

nobkd
Copy link
Contributor

@nobkd nobkd commented Feb 6, 2023

🔗 Linked issue

#1864

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Adding checks if anchor-id is present in headings, if id is not defined, the link isn't generated

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Feb 6, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Feb 6, 2023 •
edited

❌ Deploy Preview for nuxt-content failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit b455a76
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/63e197fb6482420008770bf9

farnabaz
farnabaz approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@farnabaz farnabaz merged commit ee83de8 into nuxt:main Feb 7, 2023
@nobkd nobkd deleted the fix/anchor-href-undefined branch February 7, 2023 16:21
@farnabaz farnabaz mentioned this pull request Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farnabaz farnabaz farnabaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nobkd @farnabaz