Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove favicon handling #2157

Merged
merged 2 commits into from Jul 18, 2023
Merged

fix: remove favicon handling #2157

merged 2 commits into from Jul 18, 2023

Conversation

Barbapapazes
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I remove no more needed code since this (nuxt/framework#5274 (comment)) is resolved.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jul 8, 2023

βœ… Deploy Preview for nuxt-content canceled.

Built without sensitive environment variables

Name Link
πŸ”¨ Latest commit ac36ed9
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/64ad05a5e95da300082f1ad0

@Atinux
Copy link
Member

Atinux commented Jul 10, 2023

Have you checked that when hitting /favicon.ico we don't have the document driven making a fetch call?

@Barbapapazes
Copy link
Contributor Author

In dev or in prod, I did not notice any fetch to /favicon.ico. In order to view it, I added a favicon in the document-driven playground.

Copy link
Member

Atinux commented Jul 11, 2023

The issue is actually when we don't have any public/favicon.ico, the browser will fetch it automatically.

Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that nitro return empty gif image in case of missing favicon

https://github.com/unjs/nitro/blob/1b9f51b7955d2490b1fd8da73af40780f30a1235/src/runtime/renderer.ts#L18-L26

@farnabaz farnabaz merged commit 6f5e98e into nuxt:main Jul 18, 2023
7 checks passed
@farnabaz farnabaz mentioned this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants