Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt-mdc): extract markdown parser #2187

Merged
merged 6 commits into from Jul 26, 2023
Merged

feat(nuxt-mdc): extract markdown parser #2187

merged 6 commits into from Jul 26, 2023

Conversation

farnabaz
Copy link
Member

@farnabaz farnabaz commented Jul 21, 2023

πŸ”— Linked issue

resolves #2111

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Extract Markdown parser into separate module

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link

nuxt-studio bot commented Jul 21, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
content Edit on Studio β†—οΈŽ View Live Preview 0d44a1c

@netlify
Copy link

netlify bot commented Jul 21, 2023

βœ… Deploy Preview for nuxt-content ready!

Name Link
πŸ”¨ Latest commit 0d44a1c
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/64be8056b81bc20008c2a5a0
😎 Deploy Preview https://deploy-preview-2187--nuxt-content.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nuxt-studio
Copy link

nuxt-studio bot commented Jul 21, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
content Edit on Studio β†—οΈŽ View Live Preview 2d30801

@farnabaz farnabaz marked this pull request as ready for review July 25, 2023 11:15
@farnabaz
Copy link
Member Author

Merging to test on edge release

@farnabaz farnabaz merged commit b675446 into main Jul 26, 2023
7 checks passed
@farnabaz farnabaz deleted the feat/nuxt-mdc branch July 26, 2023 12:59
@shareable-vision
Copy link
Contributor

Seems like a winning move to extract the markdown parser into its own module.

Is that code in the nuxt-mdc repo? Can I have read access?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

internal component ProseCode class attribute seems to be not working
2 participants