This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
feat(vite): upgrade to vite 2.9.0 #3974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nuxt3-docs canceled.
|
1 task
Are you sure it also triggers build warmup for entry or just doing same prebundling (of client) in background? |
|
The error is not related to Vite 2.9, but rather a misalignment that only happens on stub mode (build mode works fine). I'll investigate the issue in another PR (update: #3983) but I think it shouldn't block the improvements of having Vite 2.9.
The optimization in 2.9 becomes lazier and non-blocking, while I guess our warm-up could still benefit the initial loading time. I think we could keep it. |
antfu
previously approved these changes
Mar 31, 2022
|
Thanks @antfu! I'll restore the warm up. |
7 tasks
antfu
approved these changes
Mar 31, 2022
pi0
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
This PR upgrades to vite 2.9.0, which has a raft of new features and improvements.
Notably it adds non-blocking pre bundling of dependencies, which I think means we can drop our own pre-warming fo the server.Note: there is currently an issue with ourvite-nodeintegration. I suspect @antfu is already on it.