Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite-node): wrong entry been resolved in stub mode #3983

Merged
merged 2 commits into from Mar 31, 2022
Merged

Conversation

antfu
Copy link
Member

@antfu antfu commented Mar 31, 2022

πŸ”— Linked issue

Fixes #3974 (comment)

process.server was undefined so it resolved to the client entry and caused loaded app is an function instead of a server-rendered app.

This only happens on the stub mode of development, but not the production build.
TBH I am not sure why it's happening and if this is the correct fix.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Mar 31, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 685dbae
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/624554259de597000866ed35

@antfu antfu mentioned this pull request Mar 31, 2022
1 task
@pi0 pi0 merged commit 9c2e208 into main Mar 31, 2022
@pi0 pi0 deleted the fix/vite-node-stub branch March 31, 2022 07:11
@pi0
Copy link
Member

pi0 commented Mar 31, 2022

Thanks!

@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants