feat(nuxt)!: add NuxtPage to #components
#8145
Conversation
|
|
✅ Deploy Preview for nuxt3-docs canceled.
|
packages/nuxt/src/core/nuxt.ts
Outdated
| // Add <NuxtPage> | ||
| addComponent({ | ||
| name: 'NuxtPage', | ||
| filePath: resolve(distDir, 'pages/runtime/page') | ||
| }) |
There was a problem hiding this comment.
this should probably only be done in the pages module instead (packages/nuxt/src/pages/module.ts) - this should not be added if the pages module isn't enabled.
note that we manually register the component here:
framework/packages/nuxt/src/pages/runtime/router.ts
Lines 53 to 56 in 829a550
There was a problem hiding this comment.
yes of course 😅 .
With the components loader, is the manual register still needed ? 🤔
There was a problem hiding this comment.
Yes, let's try removing it 🤯 But let's manually import in the default app.vue file...
We've just done a very similar thing in #8167 (review).
There was a problem hiding this comment.
Since the release should happens soon (i hope so 😄), what do you think about removing NuxtChild and NuxtChild too ?
Do you mean this one
with a manual import from#components ?
There was a problem hiding this comment.
Agreed about removing deprecated components. I would do a manual relative import.
danielroe
changed the title
#components
|
Thanks! |
🔗 Linked issue
resolve nuxt/nuxt#14876
❓ Type of change
📚 Description
Hi 🙂 , this PR adds NuxtPage component to
#components📝 Checklist