Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(nuxt)!: add NuxtPage to #components #8145

Merged
merged 5 commits into from Oct 14, 2022
Merged

feat(nuxt)!: add NuxtPage to #components #8145

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
747ed76
feat(nuxt): add NuxtPage to #components
huang-julien Oct 12, 2022
be28db9
fix(nuxt): prefer add NuxtPage in page module
huang-julien Oct 12, 2022
78b31a0
perf(nuxt): remove NuxtPage manual register in router
huang-julien Oct 13, 2022
0b0bee8
refactor(nuxt): prefer relative path for NuxtPage
huang-julien Oct 13, 2022
6beb099
revert(nuxt): rely on component loader for App.vue
huang-julien Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/nuxt/src/core/nuxt.ts
View file
Open in desktop
Expand Up @@ -157,6 +157,12 @@ async function initNuxt (nuxt: Nuxt) {
filePath: resolve(nuxt.options.appDir, 'components/nuxt-loading-indicator')
})

// Add <NuxtPage>
addComponent({
name: 'NuxtPage',
filePath: resolve(distDir, 'pages/runtime/page')
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably only be done in the pages module instead (packages/nuxt/src/pages/module.ts) - this should not be added if the pages module isn't enabled.

note that we manually register the component here:

framework/packages/nuxt/src/pages/runtime/router.ts

Lines 53 to 56 in 829a550

nuxtApp.vueApp.component('NuxtPage', NuxtPage)
// TODO: remove before release - present for backwards compatibility & intentionally undocumented
nuxtApp.vueApp.component('NuxtNestedPage', NuxtPage)
nuxtApp.vueApp.component('NuxtChild', NuxtPage)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes of course 😅 .
With the components loader, is the manual register still needed ? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's try removing it 🤯 But let's manually import in the default app.vue file...

We've just done a very similar thing in #8167 (review).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the release should happens soon (i hope so 😄), what do you think about removing NuxtChild and NuxtChild too ?

Do you mean this one

framework/packages/nuxt/src/pages/runtime/app.vue

Line 3 in 829a550

<NuxtPage />
with a manual import from #components ?

Copy link
Member

@danielroe danielroe Oct 13, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed about removing deprecated components. I would do a manual relative import.


// Deprecate hooks
nuxt.hooks.deprecateHooks({
'autoImports:sources': {
Expand Down