Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ipx production support #257

Merged
merged 13 commits into from May 27, 2021
Merged

feat: ipx production support #257

merged 13 commits into from May 27, 2021

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented May 11, 2021

TODO:

  • only register ipx middleware if provider is static, ipx or empty?
  • use relative paths

closes #196, closes #187

* add documentation for manual runtime configuration
* add support for auto config with Nuxt 2.16+ and `.nuxtrc`
@danielroe danielroe changed the title fix: move ipx middleware to module feat: add automatic runtime ipx middleware May 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

Merging #257 (5ce97c9) into main (c7d4217) will increase coverage by 43.64%.
The diff coverage is 74.19%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #257       +/-   ##
===========================================
+ Coverage   13.78%   57.43%   +43.64%     
===========================================
  Files          21       24        +3     
  Lines         457      545       +88     
  Branches      136      161       +25     
===========================================
+ Hits           63      313      +250     
+ Misses        392      232      -160     
+ Partials        2        0        -2     
Impacted Files Coverage Δ
src/runtime/components/nuxt-img.vue 77.77% <ø> (ø)
src/runtime/components/nuxt-picture.vue 77.50% <ø> (ø)
src/runtime/image.ts 69.81% <ø> (+69.81%) ⬆️
src/runtime/ipx.ts 0.00% <0.00%> (ø)
src/runtime/providers/prismic.ts 85.71% <ø> (+85.71%) ⬆️
src/ipx.ts 72.00% <72.00%> (-28.00%) ⬇️
src/module.ts 96.42% <100.00%> (+3.32%) ⬆️
src/provider.ts 72.22% <100.00%> (+11.11%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7d4217...5ce97c9. Read the comment docs.

src/module.ts Outdated Show resolved Hide resolved
@pi0
Copy link
Member

pi0 commented May 11, 2021

One more note: In absence of image module (devDependencies) one needs installing ipx as a dependency! It is making me to think trade off of using normal module and depend on nitro for bundling (there is also fact that we cannot support non-node deployments like CloudFlare workers)

src/module.ts Outdated Show resolved Hide resolved
Co-authored-by: Daniel Roe <daniel@roe.dev>
@pi0 pi0 changed the title feat: add automatic runtime ipx middleware feat: ipx production May 27, 2021
@pi0 pi0 changed the title feat: ipx production feat: ipx production support May 27, 2021
@pi0 pi0 removed the pending label May 27, 2021
@pi0 pi0 mentioned this pull request May 27, 2021
5 tasks
@danielroe danielroe requested a review from pi0 May 27, 2021 15:38
@pi0 pi0 merged commit f625c92 into main May 27, 2021
@pi0 pi0 deleted the fix/runtime-ipx-module branch May 27, 2021 15:38
@danielroe danielroe mentioned this pull request Jun 4, 2021
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
Co-authored-by: Pooya Parsa <pyapar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use nuxt/image with dynamic url after the upgrade to 0.3.0 images not found 404
3 participants