Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkActiveClass doesn't work with Non-ASCII URL in SSR #3211

Closed
NemoAlex opened this issue Apr 10, 2018 · 7 comments
Closed

linkActiveClass doesn't work with Non-ASCII URL in SSR #3211

NemoAlex opened this issue Apr 10, 2018 · 7 comments
Assignees
Projects

Comments

@NemoAlex
Copy link

Version

v1.4.0

Reproduction link

https://github.com/NemoAlex/nuxt-test

Steps to reproduce

npm run dev

What is expected ?

Current link will be green.

What is actually happening?

linkActiveClass doesn't work with Non-ASCII URL in SSR. When you on /测试,refresh the browser, linkActiveClass has gone.

This bug report is available on Nuxt.js community (#c6876)
@ghost ghost added the cmty:bug-report label Apr 10, 2018
@Atinux Atinux added this to To do in Bugs 🐞 Aug 7, 2018
@Atinux
Copy link
Member

Atinux commented Aug 8, 2018

I'll cc @posva since he is the maintainer of vue-router and uses Nuxt.js as well

@posva
Copy link
Collaborator

posva commented Aug 8, 2018

I tested on a jsfiddle with only vue-router and it works correctly: https://jsfiddle.net/m9e2w4ao/

@NemoAlex
Copy link
Author

NemoAlex commented Aug 8, 2018

@posva The bug happens when you on /测试 and then refresh browser. This probably can't be tested on Jsfiddle.

@NemoAlex NemoAlex changed the title linkActiveClass doesn't work with Non-ASCII URL linkActiveClass doesn't work with Non-ASCII URL in SSR Aug 8, 2018
@manniL
Copy link
Member

manniL commented Aug 11, 2018

Possibly related: vuejs/vue-router#838 (comment)

@aldarund
Copy link

aldarund commented Sep 4, 2018

@posva it doesn't work correctly with vue router on initial load, it work correctly later but not on initial load, see example on Codesandbox in my PR vuejs/vue-router#2375

@aldarund aldarund self-assigned this Sep 23, 2018
@stale
Copy link

stale bot commented Oct 31, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Oct 31, 2018
@stale stale bot closed this as completed Nov 7, 2018
Bugs 🐞 automation moved this from Open to Fixed Nov 7, 2018
@aldarund aldarund reopened this Nov 24, 2018
Bugs 🐞 automation moved this from Fixed to Open Nov 24, 2018
@stale stale bot removed the stale label Nov 24, 2018
Bugs 🐞 automation moved this from Open to Fixed Nov 25, 2018
@lock
Copy link

lock bot commented Dec 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Bugs 🐞
  
Fixed
Development

No branches or pull requests

6 participants