Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow unicode page names #4402

Merged
merged 2 commits into from Nov 25, 2018
Merged

fix: allow unicode page names #4402

merged 2 commits into from Nov 25, 2018

Conversation

aldarund
Copy link

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves: #2888 #3211

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests passed.

@aldarund aldarund mentioned this pull request Nov 24, 2018
Closed
7 tasks
@codecov-io
Copy link

codecov-io commented Nov 24, 2018 •
edited

Codecov Report

Merging #4402 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #4402      +/-   ##
=========================================
+ Coverage   91.29%   91.3%   +<.01%     
=========================================
  Files          56      56              
  Lines        1919    1920       +1     
  Branches      482     482              
=========================================
+ Hits         1752    1753       +1     
  Misses        155     155              
  Partials       12      12
Impacted Files Coverage Δ
packages/server/src/middleware/nuxt.js 98.57% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6b7c43...9c6a7bb. Read the comment docs.

manniL
manniL reviewed Nov 25, 2018
View reviewed changes
test/fixtures/spa/nuxt.config.js Outdated Show resolved Hide resolved
packages/vue-app/package.json Show resolved Hide resolved
@aldarund aldarund changed the title fix: allow non unicode pages fix: allow unicode pages Nov 25, 2018
@aldarund aldarund changed the title fix: allow unicode pages fix: allow unicode page names Nov 25, 2018
@pi0 pi0 merged commit 949785f into dev Nov 25, 2018
@pi0 pi0 deleted the fix-unicode-urls branch November 25, 2018 14:52
pi0 pushed a commit that referenced this pull request Nov 26, 2018
@aldarund @pi0
fix(server, vue-app): allow unicode page names (#4402)
881c6a6
pi0 pushed a commit that referenced this pull request Nov 26, 2018
@aldarund @pi0
fix(server, vue-app): allow unicode page names (#4402)
d187793
pi0 added a commit that referenced this pull request Nov 26, 2018
@pi0
merge 2.x changes into dev
8cc954d 
commit 0f28f9c
Author: Pooya Parsa <pyapar@gmail.com>
Date:   Mon Nov 26 21:23:55 2018 +0330

    add simple release script

commit 16c5b89
Author: Pooya Parsa <pyapar@gmail.com>
Date:   Mon Nov 26 21:20:03 2018 +0330

    v2.3.4

commit e4a02a5
Author: Pooya Parsa <pyapar@gmail.com>
Date:   Mon Nov 26 21:17:40 2018 +0330

    whitelist CHANGELOG files

commit c96e9f4
Author: Pooya Parsa <pyapar@gmail.com>
Date:   Mon Nov 26 21:14:29 2018 +0330

    lerna auto tag

commit be126bd
Author: Pooya Parsa <pyapar@gmail.com>
Date:   Mon Nov 26 21:12:22 2018 +0330

    remove extra gitHead

commit eefa130
Author: Pooya Parsa <pyapar@gmail.com>
Date:   Mon Nov 26 21:09:31 2018 +0330

    hotfix: build on prepublish hook

commit d0af6a4
Author: Sébastien Chopin <seb@chopin.io>
Date:   Mon Nov 26 18:37:12 2018 +0100

    bump: Bump to v2.3.3

commit 2e90166
Author: Pooya Parsa <pyapar@gmail.com>
Date:   Mon Nov 26 20:32:11 2018 +0330

    update @nuxtjs/opencollective to 0.2.0

commit f10c982
Author: renovate[bot] <renovate[bot]@users.noreply.github.com>
Date:   Mon Nov 26 20:24:49 2018 +0330

    chore(deps): update dependency vue-meta to ^1.5.6 (#4427)

commit b7285fe
Author: Pooya Parsa <pyapar@gmail.com>
Date:   Mon Nov 26 20:05:18 2018 +0330

    remove build with devtools tests as feature is not merged yet

commit b582e70
Author: Pooya Parsa <pyapar@gmail.com>
Date:   Mon Nov 26 19:58:34 2018 +0330

    update patch-only dependencies

commit 289d30f
Author: Pooya Parsa <pyapar@gmail.com>
Date:   Mon Nov 26 19:55:51 2018 +0330

    remove typings

commit 7e1beed
Author: Dmitry Molotkov <aldarund@gmail.com>
Date:   Sun Nov 25 17:48:13 2018 +0300

    perf(pkg): remove lodash dependency from packages (#4411)

commit 4a85c03
Author: Pooya Parsa <pyapar@gmail.com>
Date:   Sun Nov 25 22:46:19 2018 +0330

    fix(pkg): move opencollective dependency nuxt and nuxt-legacy (#4415)

commit d187793
Author: Dmitry Molotkov <aldarund@gmail.com>
Date:   Sun Nov 25 17:52:37 2018 +0300

    fix(server, vue-app): allow unicode page names (#4402)

commit e1c1240
Author: Alexander Lichter <manniL@gmx.net>
Date:   Sun Nov 25 14:51:32 2018 +0000

    fix(server, jsdom): fix timeout error message (#4412)

    [skip release]

commit 0c6c69b
Author: Alexander Lichter <manniL@gmx.net>
Date:   Sat Nov 24 21:35:43 2018 +0000

    fix(scrollBehavior): emit triggerScroll event after changing layer (#4399)

    resolves: #4080

commit 8030ca1
Author: Alexander Lichter <manniL@gmx.net>
Date:   Sat Nov 24 18:30:28 2018 +0000

    fix(progress-bar): allow 0 for values and remove duplicate defaults (#4397)

commit 54d2737
Author: Clark Du <clark.duxin@gmail.com>
Date:   Sat Nov 24 00:02:13 2018 +0000

    fix: router Expected "0" to be defined (#4394)

commit 47f02ae
Author: Clark Du <clark.duxin@gmail.com>
Date:   Fri Nov 23 22:34:05 2018 +0000

    fix: empty error message in dev mode

commit ff7c083
Author: Clark Du <clark.duxin@gmail.com>
Date:   Thu Nov 22 15:48:26 2018 +0000

    fix: modern=true or false not work as expected (#4378)
@lock
Copy link

lock bot commented Dec 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 25, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manniL manniL manniL approved these changes

@pi0 pi0 pi0 approved these changes

@clarkdo clarkdo Awaiting requested review from clarkdo

Assignees
No one assigned
Labels
2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JS execution silently fails on a statically generated site
5 participants
@aldarund @codecov-io @manniL @pi0 @danielroe