Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxi,schema): add support for setting nuxt logLevel #19369

Merged
merged 22 commits into from Mar 7, 2023

Conversation

Baroshem
Copy link
Contributor

@Baroshem Baroshem commented Mar 1, 2023

resolves #18656
resolves #18497

This PR adds a logLevel option to basic nuxi commands and build that is then used to set certain log visibility for underlying builder (either vite or webpack).

Three main log levels have been defined:

  1. silent - converted to none in webpack and silent in vite
  2. info - converted to normal in webpack and info in vite
  3. verbose - converted to verbose in webpack and info in vite

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Mar 1, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@Baroshem Baroshem marked this pull request as ready for review March 3, 2023 09:39
@Baroshem Baroshem requested review from pi0 and danielroe March 7, 2023 08:11
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid to me! ❀️

packages/vite/src/vite.ts Outdated Show resolved Hide resolved
@Baroshem
Copy link
Contributor Author

Baroshem commented Mar 7, 2023

Wow, @danielroe is so fast with adding improvements to my code that I just see that there were conversations resolved and commits added πŸ˜„

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielroe danielroe changed the title feat(nuxi): add logLevel support feat(nuxi,schema): add support for setting nuxt logLevel Mar 7, 2023
@danielroe danielroe merged commit 3f1e023 into nuxt:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI commands quiet mode Quiet mode
3 participants