Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxi): resolve kit from nuxt modules dir #19601

Merged
merged 3 commits into from Mar 11, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

#14146

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

For pnp support, we should resolve kit from (1) local install and then (2) from the nuxt dependency. This means we do not need to add @nuxt/kit as a dependency without shamefully-hoist.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Mar 11, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe requested a review from antfu March 11, 2023 20:43
@danielroe danielroe added this to the v3.3 milestone Mar 11, 2023
@danielroe danielroe added the 3.x label Mar 11, 2023
@danielroe danielroe merged commit 3684de5 into main Mar 11, 2023
@danielroe danielroe deleted the fix/pnpm-resolve-kit branch March 11, 2023 22:36
This was referenced Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant