Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): allow vite and webpack plugins to be prepended #20403

Merged
merged 4 commits into from Apr 29, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

https://github.com/nuxt/nuxt/pull/20367/files

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds a prepend option to addWebpackPlugin and addVitePlugin to allow plugins to be prepended to the start of the plugins list.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Apr 19, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe changed the title feat: allow vite plugins to be prepended feat(kit): allow vite and webpack plugins to be prepended Apr 19, 2023
@danielroe danielroe added this to the v3.5 milestone Apr 20, 2023
@pi0
Copy link
Member

pi0 commented Apr 21, 2023

About naming of option, preprend is more consistent with previous kit options we had. But also enforce: pre|past could be useful IMO since plugins adopting it.

@danielroe danielroe merged commit b2a1f9f into main Apr 29, 2023
17 checks passed
@danielroe danielroe deleted the feat/plugin-prepend branch April 29, 2023 22:39
@github-actions github-actions bot mentioned this pull request Apr 29, 2023
@github-actions github-actions bot mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants