Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kit): allow vite and webpack plugins to be prepended #20403

Merged
merged 4 commits into from Apr 29, 2023
Merged

feat(kit): allow vite and webpack plugins to be prepended #20403

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00a544e
feat: allow vite plugins to be prepended
posva Apr 12, 2023
57436f1
feat: add parallel webpack option
danielroe Apr 19, 2023
0c208ee
refactor: make prepend a shared option
danielroe Apr 29, 2023
602a10c
Merge remote-tracking branch 'origin/main' into feat/plugin-prepend
danielroe Apr 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 11 additions & 6 deletions packages/kit/src/build.ts
View file
Open in desktop
Expand Up @@ -27,10 +27,13 @@ export interface ExtendConfigOptions {
* @default true
*/
client?: boolean
/**
* Prepends the plugin to the array with `unshit()` instead of `push()`.
*/
prepend?: boolean
}

export interface ExtendWebpackConfigOptions extends ExtendConfigOptions {
}
export interface ExtendWebpackConfigOptions extends ExtendConfigOptions {}

export interface ExtendViteConfigOptions extends ExtendConfigOptions {}

Expand Down Expand Up @@ -104,12 +107,13 @@ export function extendViteConfig (
* Append webpack plugin to the config.
*/
export function addWebpackPlugin (plugin: WebpackPluginInstance | WebpackPluginInstance[], options?: ExtendWebpackConfigOptions) {
const method: 'push' | 'unshift' = options?.prepend ? 'unshift' : 'push'
extendWebpackConfig((config) => {
config.plugins = config.plugins || []
if (Array.isArray(plugin)) {
config.plugins.push(...plugin)
config.plugins[method](...plugin)
} else {
config.plugins.push(plugin)
config.plugins[method](plugin)
}
}, options)
}
Expand All @@ -118,12 +122,13 @@ export function addWebpackPlugin (plugin: WebpackPluginInstance | WebpackPluginI
* Append Vite plugin to the config.
*/
export function addVitePlugin (plugin: VitePlugin | VitePlugin[], options?: ExtendViteConfigOptions) {
const method: 'push' | 'unshift' = options?.prepend ? 'unshift' : 'push'
extendViteConfig((config) => {
config.plugins = config.plugins || []
if (Array.isArray(plugin)) {
config.plugins.push(...plugin)
config.plugins[method](...plugin)
} else {
config.plugins.push(plugin)
config.plugins[method](plugin)
}
}, options)
}