fix(nuxt): don't refresh when hydrating when data is present
#20916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
changed the title
refresh calls when hydrating (if data is present)refresh when hydrating when data is present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #20900
❓ Type of change
📚 Description
It's an edge case, but when calling
executeorrefreshwe will force refresh data on initial load of a component (ie. when hydrating), because we don't pass the{ _initial: true }option by default.This PR updates behaviour to default to skipping refresh of data if it exists in payload and we're hydrating. It can still be overridden by passing
{ _initial: false }. I don't regard this as a breaking change as changing data in the payload will almost always be incorrect and cause a hydration failure.📝 Checklist