Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): don't refresh when hydrating when data is present #20916

Merged
merged 4 commits into from May 17, 2023
Merged

fix(nuxt): don't refresh when hydrating when data is present #20916

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
633bc29
fix(nuxt): ignore `refresh` calls when hydrating (if data is present)
danielroe May 17, 2023
e2e6ace
fix: allow overriding `_initial`
danielroe May 17, 2023
6229150
test: update fixture to pass `_initial: false`
danielroe May 17, 2023
2dbd2b4
test: also update other line 🙈
danielroe May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nuxt/src/app/composables/asyncData.ts
View file
Open in desktop
Expand Up @@ -135,7 +135,7 @@ export function useAsyncData<
(nuxt._asyncDataPromises[key] as any).cancelled = true
}
// Avoid fetching same key that is already fetched
if (opts._initial && hasCachedData()) {
if ((opts._initial || (nuxt.isHydrating && opts._initial !== false)) && hasCachedData()) {
return getCachedData()
}
asyncData.pending.value = true
Expand Down