Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): compute fetch cache key with headers #23462

Merged
merged 1 commit into from Oct 2, 2023
Merged

fix(nuxt): compute fetch cache key with headers #23462

merged 1 commit into from Oct 2, 2023

Conversation

hendrikheil
Copy link
Contributor

πŸ”— Linked issue

#23455

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #23455 by including the request headers in the key used for caching requests. This behavior is what I expected, and solves requests not being sent like when used in Laravel Precognitive requests.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Sep 28, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe requested a review from pi0 September 29, 2023 07:07
@danielroe danielroe changed the title fix: compute fetch cache key with headers fix(nuxt): compute fetch cache key with headers Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider headers in useFetch key
2 participants