Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): include plugin templates in plugins.d.ts if they will be written #23943

Merged
merged 3 commits into from Nov 9, 2023
Merged

fix(nuxt): include plugin templates in plugins.d.ts if they will be written #23943

merged 3 commits into from Nov 9, 2023

Conversation

nasrob
Copy link
Contributor

@nasrob nasrob commented Oct 25, 2023

🔗 Linked issue

#22617

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #22617

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Oct 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe changed the title fix(nuxt): fixed plugin registration into plugins.d.ts #22617 fix(nuxt): include plugin templates that will be written in plugins.d.ts Nov 9, 2023
@danielroe danielroe changed the title fix(nuxt): include plugin templates that will be written in plugins.d.ts fix(nuxt): include plugin templates in plugins.d.ts if they will be written Nov 9, 2023
@danielroe danielroe merged commit bb533f8 into nuxt:main Nov 9, 2023
35 checks passed
@github-actions github-actions bot mentioned this pull request Nov 9, 2023
Merged
manniL pushed a commit that referenced this pull request Dec 11, 2023
@nasrob @danielroe @manniL
fix(nuxt): include plugin templates in plugins.d.ts if they will be…
57e5400 
… written (#23943)

Co-authored-by: Daniel Roe <daniel@roe.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe left review comments

Assignees
No one assigned
Labels
3.x bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin created from a template doesn't get registered into plugins.d.ts
2 participants
@nasrob @danielroe