Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): include plugin templates in plugins.d.ts if they will be written #23943

Merged
merged 3 commits into from Nov 9, 2023
Merged

fix(nuxt): include plugin templates in plugins.d.ts if they will be written #23943

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ac9e3a
fix(nuxt): fixed plugin registration into `plugins.d.ts` #22617
nasrob Oct 25, 2023
8fd900f
fix: update test
danielroe Nov 9, 2023
2e9c81f
perf: make more readable + use single iteration
danielroe Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nuxt/src/core/templates.ts
View file
Open in desktop
Expand Up @@ -103,7 +103,7 @@ export const pluginsDeclaration: NuxtTemplate<TemplateContext> = {
getContents: (ctx) => {
const EXTENSION_RE = new RegExp(`(?<=\\w)(${ctx.nuxt.options.extensions.map(e => escapeRE(e)).join('|')})$`, 'g')
const tsImports = ctx.app.plugins
.filter(p => !isAbsolute(p.src) || existsSync(p.src) || existsSync(p.src.replace(EXTENSION_RE, '.d.ts')))
.filter(p => !isAbsolute(p.src) || existsSync(p.src) || (p.src.includes('.d.ts') && existsSync(p.src.replace(EXTENSION_RE, '.d.ts'))))
danielroe marked this conversation as resolved.
Show resolved Hide resolved
danielroe marked this conversation as resolved.
Show resolved Hide resolved
.map(p => (isAbsolute(p.src) ? relative(join(ctx.nuxt.options.buildDir, 'types'), p.src) : p.src).replace(EXTENSION_RE, ''))

return `// Generated by Nuxt'
Expand Down