fix(nuxt): handle errors when booting app with app:error
#24376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
antfu
commented
Nov 20, 2023
packages/nuxt/src/app/entry.ts
Outdated
| @@ -76,6 +85,8 @@ if (import.meta.client) { | |||
| nuxt.payload.error = (nuxt.payload.error || err) as any | |||
| } | |||
|
|
|||
| vueApp.config.errorHandler = prevVueErrorHandler | |||
There was a problem hiding this comment.
Reset back to undefined. Or should we actually always provide the handler with a better experience?
There was a problem hiding this comment.
Interesting question. I'd be up for always providing an error handler.
danielroe
approved these changes
Nov 20, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24376 +/- ##
=======================================
Coverage ? 58.76%
=======================================
Files ? 5
Lines ? 861
Branches ? 46
=======================================
Hits ? 506
Misses ? 355
Partials ? 0 ☔ View full report in Codecov by Sentry. |
danielroe
reviewed
Nov 20, 2023
|
|
danielroe
changed the title
app:error
Merged
manniL
pushed a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a custom
errorHandler, Vue will throw an error and crash itself in dev, causing Vue's singleton context has a broken state. In that case, it will cause off-root apps (anothercreateApp) to fail to work. Nuxt DevTools creates a separate app to mount itself, and this PR fixes that DevTools does not work on the error page.This probably also improves the error capture in Production? As in production, unhandled error are not thrown, make the
try catchinentry.tsnot been able to capture them.