Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): handle errors when booting app with app:error #24376

Merged
merged 6 commits into from Nov 20, 2023
Merged

fix(nuxt): handle errors when booting app with app:error #24376

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d958db3
fix(nuxt): provide error handler on init app
antfu Nov 20, 2023
9920e47
[autofix.ci] apply automated fixes
autofix-ci[bot] Nov 20, 2023
428f89f
chore: improve logic
antfu Nov 20, 2023
6eaf72b
refactor: remove some duplicate logic
danielroe Nov 20, 2023
fe21e97
Merge remote-tracking branch 'origin/main' into feat/vue-handle-error
danielroe Nov 20, 2023
bc8c5a9
[autofix.ci] apply automated fixes
autofix-ci[bot] Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 13 additions & 4 deletions packages/nuxt/src/app/entry.ts
View file
Open in desktop
Expand Up @@ -58,11 +58,17 @@ if (import.meta.client) {

const nuxt = createNuxtApp({ vueApp })

async function handleVueError(err: any) {
await nuxt.callHook('app:error', err)
nuxt.payload.error = (nuxt.payload.error || err) as any
}

vueApp.config.errorHandler = handleVueError

try {
await applyPlugins(nuxt, plugins)
} catch (err) {
await nuxt.callHook('app:error', err)
nuxt.payload.error = (nuxt.payload.error || err) as any
handleVueError(err)
}

try {
Expand All @@ -72,10 +78,13 @@ if (import.meta.client) {
await nuxt.hooks.callHook('app:mounted', vueApp)
await nextTick()
} catch (err) {
await nuxt.callHook('app:error', err)
nuxt.payload.error = (nuxt.payload.error || err) as any
handleVueError(err)
}

// If the errorHandler is not overridden by the user, we unset it
if (vueApp.config.errorHandler === handleVueError)
vueApp.config.errorHandler = undefined

return vueApp
}

Expand Down