fix(schema): disable typescript.shim by default in favour of volar features
#26052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takeover Mode has been deprecated. "TypeScript Vue Plugin" extension has been deprecated.
|
|
danielroe
reviewed
Mar 3, 2024
| @@ -50,8 +50,7 @@ export default defineUntypedSchema({ | |||
| /** | |||
| * Generate a `*.vue` shim. | |||
| * | |||
| * We recommend instead either enabling [**Take Over Mode**](https://vuejs.org/guide/typescript/overview.html#volar-takeover-mode) or adding | |||
| * TypeScript Vue Plugin (Volar)** 👉 [[Download](https://marketplace.visualstudio.com/items?itemName=Vue.vscode-typescript-vue-plugin)]. | |||
| * We recommend instead installing the [official Vue extension](https://marketplace.visualstudio.com/items?itemName=Vue.volar). | |||
| */ | |||
| shim: true | |||
There was a problem hiding this comment.
We should update the default to false in this case.
Can we combine this with your other pr?
Takeover Mode has been deprecated. "TypeScript Vue Plugin" extension has been deprecated.
✅ Live Preview ready!
|
danielroe
changed the title
typescript.shim by default in favour of volar features
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takeover Mode has been deprecated.
"TypeScript Vue Plugin" extension has been deprecated.
closes #26051