Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schema): disable typescript.shim by default in favour of volar features #26052

Merged
merged 7 commits into from
Mar 5, 2024
Merged

fix(schema): disable typescript.shim by default in favour of volar features #26052

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
80edc3b
docs(shim): update recommendations
oumarbarry Mar 3, 2024
314639d
docs(installation): update additional notes
oumarbarry Mar 3, 2024
625385c
Merge remote-tracking branch 'origin/main' into patch-2
danielroe Mar 4, 2024
7d4e17a
fix(schema): disable shim by default
danielroe Mar 4, 2024
1cab1b5
docs: remove additional notes about volar
danielroe Mar 4, 2024
c518fc9
docs: further update
danielroe Mar 4, 2024
99266e8
docs: use `typescript.shim` for shiki twoslash
danielroe Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/schema/src/config/typescript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ export default defineUntypedSchema({
/**
* Generate a `*.vue` shim.
*
* We recommend instead either enabling [**Take Over Mode**](https://vuejs.org/guide/typescript/overview.html#volar-takeover-mode) or adding
* TypeScript Vue Plugin (Volar)** 👉 [[Download](https://marketplace.visualstudio.com/items?itemName=Vue.vscode-typescript-vue-plugin)].
* We recommend instead installing the [official Vue extension](https://marketplace.visualstudio.com/items?itemName=Vue.volar).
*/
shim: true
Copy link
Member

@danielroe danielroe Mar 3, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the default to false in this case.

Can we combine this with your other pr?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah for sure

}
Expand Down