Skip to content

fix(nuxt): handle underscores in island names #26370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking โ€œSign up for GitHubโ€, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Conversation

danielroe
Copy link
Member

๐Ÿ”— Linked issue

resolves #26362

โ“ Type of change

  • ๐Ÿ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • โœจ New feature (a non-breaking change that adds functionality)
  • ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

Before we introduced island pages, it was safe to use _ as a separator for the name + hash in island components. However, that is no longer safe as page names may well use them. This PR updates to use a regular expression rather than string manipulation based on _.

๐Ÿ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Sorry, something went wrong.

Verified

This commit was signed with the committerโ€™s verified signature.
danielroe Daniel Roe
Copy link

stackblitz bot commented Mar 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe requested a review from huang-julien March 19, 2024 11:04

Verified

This commit was signed with the committerโ€™s verified signature.
danielroe Daniel Roe

Verified

This commit was signed with the committerโ€™s verified signature.
danielroe Daniel Roe
@danielroe danielroe merged commit 5de7244 into main Mar 20, 2024
34 checks passed
@danielroe danielroe deleted the fix/underscore-islands branch March 20, 2024 00:01
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout breaks when name of server-only page is changed via extendPages
2 participants