Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nuxt): handle underscores in island names #26370

Merged
merged 3 commits into from
Mar 20, 2024
Merged

fix(nuxt): handle underscores in island names #26370

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
481efac
fix(nuxt): handle underscores in island names
danielroe Mar 19, 2024
f28a60c
fix(nuxt): handle missing `hashId`
danielroe Mar 19, 2024
adb6633
fix: set hashId to undefined
danielroe Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/nuxt/src/core/runtime/nitro/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,15 +205,17 @@ const sharedPrerenderCache = import.meta.prerender && process.env.NUXT_SHARED_DA
}
: null

const ISLAND_SUFFIX_RE = /\.json(\?.*)?$/
async function getIslandContext (event: H3Event): Promise<NuxtIslandContext> {
// TODO: Strict validation for url
let url = event.path || ''
if (import.meta.prerender && event.path && await islandPropCache!.hasItem(event.path)) {
// rehydrate props from cache so we can rerender island if cache does not have it any more
url = await islandPropCache!.getItem(event.path) as string
}
url = url.substring('/__nuxt_island'.length + 1) || ''
const [componentName, hashId] = url.split('?')[0].replace(/\.json$/, '').split('_')
const componentParts = url.substring('/__nuxt_island'.length + 1).replace(ISLAND_SUFFIX_RE, '').split('_')
const hashId = componentParts.length > 1 ? componentParts.pop() : undefined
const componentName = componentParts.join('_')

// TODO: Validate context
const context = event.method === 'GET' ? getQuery(event) : await readBody(event)
Expand Down