Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): fallback for empty chunk name #7667

Merged
merged 8 commits into from Jul 4, 2020
Merged

fix(webpack): fallback for empty chunk name #7667

merged 8 commits into from Jul 4, 2020

Conversation

simllll
Copy link

@simllll simllll commented Jul 3, 2020

fixes #7665

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

if all chunks have no name, it results to an empty compactName. Due to #7639 this results into file paths like /common/.xxx.js. As files with a dot at the beginnign are not served, this is a problem ;-)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2020

Codecov Report

Merging #7667 into dev will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7667      +/-   ##
==========================================
- Coverage   70.18%   70.14%   -0.04%     
==========================================
  Files          88       88              
  Lines        3756     3758       +2     
  Branches     1019     1020       +1     
==========================================
  Hits         2636     2636              
- Misses        911      912       +1     
- Partials      209      210       +1     
Flag Coverage Δ
#unittests 70.14% <0.00%> (-0.04%) ⬇️
Impacted Files Coverage Δ
packages/webpack/src/config/client.js 61.17% <0.00%> (-1.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3821ba...ac60eb3. Read the comment docs.

@pi0 pi0 changed the title fix(webpack): fallback for empty chunk names fix(webpack): fallback for empty chunk name Jul 4, 2020
pi0
pi0 previously approved these changes Jul 4, 2020
@simllll
Copy link
Author

simllll commented Jul 4, 2020

Lgtm

@pi0 pi0 merged commit b4ffdab into nuxt:dev Jul 4, 2020
@pi0
Copy link
Member

pi0 commented Jul 4, 2020

Thanks @simllll. Would you please confirm it working using nuxt-edge before doing release? (should be published in few minutes)

@simllll
Copy link
Author

simllll commented Jul 4, 2020

@pi0 just tested it, I can confirm the issue is fixed in nuxt-edge. looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

since nuxt@2.13.3 some modern files are missing?
5 participants