Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): transpile ufo #8846

Merged
merged 1 commit into from
Feb 17, 2021
Merged

fix(webpack): transpile ufo #8846

merged 1 commit into from
Feb 17, 2021

Conversation

kn3ny
Copy link

@kn3ny kn3ny commented Feb 17, 2021

Add ufo module, instead of @nuxt/ufo, to the default target of transpile.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

There is a commit 7529d65 that migrates from @nuxt/ufo to ufo. However, it seems migration of the configuration of transpiling was not included.
Since ufo will not be transpiled by default, user's nuxt.js app will be broken on old browsers such as IE.

Resolves: #8838, #8839

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@kn3ny kn3ny marked this pull request as ready for review February 17, 2021 13:43
@pi0 pi0 changed the title fix(webpack): follow up migrating from @nuxt/ufo to ufo fix(webpack): transpile ufo Feb 17, 2021
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit ba44b0f into nuxt:dev Feb 17, 2021
@pi0 pi0 mentioned this pull request Feb 19, 2021
This was referenced Mar 10, 2021
This was referenced Mar 12, 2021
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 'SCRIPT1053' occurs on IE11 (nuxt: v2.15.0)
3 participants