Support new OCaml 5 unix primitive names #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can specify a range; I'll find back. |
|
after checking in https://github.com/ocaml-batteries-team/batteries-included/blob/master/build/prefilter.ml; apparently not |
|
but, there is a use example in src/batteries_compattest.mlv: ##V>=4.7####V<4.14##` module Seq = (Seq : module type of Legacy.Seq) |
|
If you can use this kind of syntax and your tests work; I'll merge your proposed change |
dra27
force-pushed
the
check-symbols-caml_unix
branch
from
4cbae4c
to
9b4ffa1
Compare
|
Ah, thanks - I didn't spot that! Updated to use it, and I checked that it's building correctly on 4.12 still and pre-processing correctly on 5.0 (there are other fixes needed for OCaml 5 support - I'm only dealing with the bit I've broken here 🙂) |
|
thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler is considering ensuring all symbols in the Unix library are prefixed
caml_for 5.0 (ocaml/ocaml#10926).This affects batteries only for the
unix_linkprimitive which is updated here. I couldn't see that there was a way to specify a range of versions for##Vmarkers, so apologies for the slightly convoluted way of selecting between 3 differentexternaldeclarations!