Use index-based stash references #1270
Merged
+2
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I think a good commit message would be |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1270 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 735 733 -2
Branches 198 197 -1
=========================================
- Hits 735 733 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
iiroj
approved these changes
Mar 8, 2023
Merged
|
Thanks for merging! And sorry I had not realized you're using semantic PR titles here, I'll adapt to that for future PRs |
|
This will be published to npm when #1272 is merged, because of some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1267
Following the discussion in #1267 I'm making this PR here to make the suggested change. Please see the issue for more details.
This also means we can remove the MSYS workaround, and the corresponding test.