Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use index-based stash references #1270

Merged
merged 1 commit into from Mar 8, 2023

Conversation

marcelltoth
Copy link
Contributor

@marcelltoth marcelltoth commented Mar 8, 2023

Fixes #1267

Following the discussion in #1267 I'm making this PR here to make the suggested change. Please see the issue for more details.

This also means we can remove the MSYS workaround, and the corresponding test.

@iiroj
Copy link
Member

iiroj commented Mar 8, 2023

Thanks for the PR! I think a good commit message would be fix: use index-based stash references for improved MSYS2 compatibility, but I can reword it when merging.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (0d843ce) 100.00% compared to head (da82500) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1270   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          735       733    -2     
  Branches       198       197    -1     
=========================================
- Hits           735       733    -2     
Impacted Files Coverage Δ
lib/gitWorkflow.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iiroj iiroj merged commit 60fcd99 into lint-staged:master Mar 8, 2023
16 checks passed
@iiroj iiroj mentioned this pull request Mar 8, 2023
@marcelltoth marcelltoth deleted the use-stash-index branch March 9, 2023 11:33
@marcelltoth
Copy link
Contributor Author

Thanks for merging! And sorry I had not realized you're using semantic PR titles here, I'll adapt to that for future PRs

@iiroj
Copy link
Member

iiroj commented Mar 9, 2023

This will be published to npm when #1272 is merged, because of some semantic-release issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

MSYS2 "fix" broke lint-staged on my MSYS2 setup
2 participants