Upgrade to newer version of stylelint #132
Comments
|
u needed to upgrade stylelint plugin |
|
Did you see this @olegskl? Currently, stylelint v15 can't be used with this plugin. |
|
Can this be done @olegskl? |
|
I have sent a PR #138 but in case nothing happens my fork works fine for itself. For someone else who relies on gulp-stylelint in their daily work like me, please install my fork to your project, I try to keep its stylelint and dependencies up to date: npm install @ronilaukkarinen/gulp-stylelint --save-devTested & working just now. |
|
Thank you, Roni! BTW force installing gulp-stylelint with stylelint v15 works, didn't notice any issues. |
|
Yeah it works if you are forcing them inside gulp-stylelint but if you want to use the stable tag in projects without going through the node module level you have to do the installs separately. |
|
@olegskl any update on this? |
Yeah, but force-installing is always a bad practice as it may lead to other unexpected errors. |
While looking at what would be needed for govuk-frontend to adopt a stylelint 14 compatible release of styleint-config-gds [1] I discovered that a blocker for that upgrade is the use of gulp-stylelint [2] which only officially supports Stylelint up to version 13 and doesn't seem to be actively iterated. There didn't seem to be much that was lost by removing gulp-stylelint, it actually made SCSS linting consistent with the approach taken for JS. As the command to run stylelint is longer than standard I added additional tasks to the NPM file that are consistent for both JS and SCSS linting. [1]: alphagov/stylelint-config-gds#22 [2]: olegskl/gulp-stylelint#132
While looking at what would be needed for govuk-frontend to adopt a stylelint 14 compatible release of styleint-config-gds [1] I discovered that a blocker for that upgrade is the use of gulp-stylelint [2] which only officially supports Stylelint up to version 13 and doesn't seem to be actively iterated. There didn't seem to be much that was lost by removing gulp-stylelint, it actually made SCSS linting consistent with the approach taken for JS. As the command to run stylelint is longer than standard I added additional tasks to the NPM file that are consistent for both JS and SCSS linting. [1]: alphagov/stylelint-config-gds#22 [2]: olegskl/gulp-stylelint#132
While looking at what would be needed for govuk-frontend to adopt a stylelint 14 compatible release of styleint-config-gds [1] I discovered that a blocker for that upgrade is the use of gulp-stylelint [2] which only officially supports Stylelint up to version 13 and doesn't seem to be actively iterated. There didn't seem to be much that was lost by removing gulp-stylelint, it actually made SCSS linting consistent with the approach taken for JS. As the command to run stylelint is longer than standard I added additional tasks to the NPM file that are consistent for both JS and SCSS linting. I've used quotes around the paths as it seems they were being expanded by the OS rather than by stylelint and using quotes forces stylelint to do so. [1]: alphagov/stylelint-config-gds#22 [2]: olegskl/gulp-stylelint#132
|
Thank you @ronilaukkarinen !! #132 (comment) works great. But an official release would be nice for everyone. @olegskl can you please release a v14? I see #138 is merged so we should be pretty close, right? High-fives to the Open Source community 🤚 ☮️ |
|
Is there new version planned soon? Would be great to be able to upgrade to stylelint 14 and afterwards. |
|
@Gomes81 No, it is not as we have not heard the maintainer @olegskl for almost 3 years now. My fork still works, see the comment earlier on this issue. |
|
Too bad @olegskl has seemingly abandoned this project 🙄 this doesn't seem like it'd be that hard to fix, especially given there's a PR... @ronilaukkarinen, any chance you can update your fork? Looks like it's not compatible with stylelint v16 |
|
Yes, there is a pending PR, but I'm still using v15 for stylelint plugins that depend on gulp-stylelint v16 and haven't been able to get migrated those yet. Scheduled for January 2024 with our team, I'll get back to this as soon as I can. Ref: #10. |
|
Maybe @XhmikosR can help ? |
|
Hey @olegskl where are you ? |
Hello,
I had some trouble getting gulp-stylelint working. As a config is needed, I installed stylelint-config-recommanded,
npm install stylelint-config-recommended --save-devBut newer version 4.0.0 of this package throw this error :
'Undefined rule declaration-block-no-duplicate-custom-properties' (as it's only compatible with 13.12 version of stylelint)
And previous version 3.0.0 doesn't work either, with this error :
'Undefined rule function-calc-no-invalid' (as it only compatible with stylelint version > 10.1.0)
So I had to switch back to version 2.2.0 that is compatible with stylelint ^8.0 version provided by gulp-stylelint.
Could you upgrade from 8.0.0 that was released in mid-2017 to latest version that was released on 6 march of this year ?
The text was updated successfully, but these errors were encountered: