This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
Adding collection-like mapping to Change. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrogccom Thanks for the PR, added some comments |
onmyway133
reviewed
Mar 6, 2019
| import Foundation | ||
|
|
||
| public extension Change { | ||
| public func map<U>(_ transform: (T) throws -> U) rethrows -> Change<U> { |
There was a problem hiding this comment.
@jrogccom can we go with 2 spaces ?
There was a problem hiding this comment.
@onmyway133 Absolutely. I'll do it manually, but is there a linter you use?
There was a problem hiding this comment.
I haven't configured SwiftLint for this
onmyway133
reviewed
Mar 6, 2019
| switch self { | ||
| case .delete(let value): | ||
| return try .delete(Delete(item: transform(value.item), index: value.index)) | ||
|
|
There was a problem hiding this comment.
I would prefer no empty lines here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapping changes can be useful when inspecting and acting on changes without revealing private types to internal or public interfaces.